Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Fix MSI installation parameters for non-admin Windows installations#261

Merged
jhaynie merged 1 commit intomainfrom
devin/1746066925-fix-windows-installer-msi-params
May 1, 2025
Merged

Fix MSI installation parameters for non-admin Windows installations#261
jhaynie merged 1 commit intomainfrom
devin/1746066925-fix-windows-installer-msi-params

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Fix MSI installation parameters for non-admin Windows installations

Description

This PR fixes an issue with the Windows installer when running as a non-administrator where the executable wasn't being installed to the AppData/Local/Agentuity folder.

The root cause was that the MSI installer was always using ALLUSERS=1 parameter, which forces a system-wide installation requiring administrator privileges. For non-admin installations, we need to use ALLUSERS=0 to ensure the executable is installed to the user's AppData/Local/Agentuity folder.

Changes

  • Modified the MSI installation parameters to use ALLUSERS=0 for non-admin installations
  • Kept ALLUSERS=1 for admin installations to maintain system-wide installation behavior

Testing

The changes have been tested to ensure:

  • Admin installations continue to work as before
  • Non-admin installations correctly install to AppData/Local/Agentuity
  • The executable is properly placed in the installation directory
  • PATH is correctly updated for the current session

Link to Devin run: https://app.devin.ai/sessions/5272ebfb3df545818bcd66907319869b
Requested by: jhaynie@agentuity.com

…ation to AppData/Local/Agentuity

- Keep ALLUSERS=1 for admin installations to maintain system-wide installation behavior

Co-Authored-By: jhaynie@agentuity.com <jhaynie@gmail.com>
@devin-ai-integration devin-ai-integration Bot requested a review from jhaynie May 1, 2025 02:38
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@jhaynie jhaynie merged commit 8b27727 into main May 1, 2025
12 checks passed
@jhaynie jhaynie deleted the devin/1746066925-fix-windows-installer-msi-params branch May 1, 2025 03:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant